diff --git a/extras/golang/0001-Modify-go.env.patch b/extras/golang/0001-Modify-go.env.patch new file mode 100644 index 0000000..d50ce0e --- /dev/null +++ b/extras/golang/0001-Modify-go.env.patch @@ -0,0 +1,31 @@ +From fbcfe983cdeb723420d67364022fc91ac8c6be3c Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Alejandro=20S=C3=A1ez?= +Date: Wed, 5 Jun 2024 12:30:46 +0200 +Subject: [PATCH] Modify environment variables defaults + +- Set GOTOOLCHAIN to local +- Set GOAMD64 to v3 +- Set GOPPC64 to power9 +--- + go.env | 8 +++++++- + 1 file changed, 7 insertions(+), 1 deletion(-) + +diff --git a/go.env b/go.env +index 6ff2b921d4..0bff84446c 100644 +--- a/go.env ++++ b/go.env +@@ -9,4 +9,10 @@ GOSUMDB=sum.golang.org + + # Automatically download newer toolchains as directed by go.mod files. + # See https://go.dev/doc/toolchain for details. +-GOTOOLCHAIN=auto ++GOTOOLCHAIN=local ++ ++# The AMD64 baseline for RHEL10 is v3. ++GOAMD64=v3 ++# The PPC64LE baseline for RHEL10 is power9 ++GOPPC64=power9 ++ +-- +2.45.1 + diff --git a/extras/golang/0006-Default-to-ld.bfd-on-ARM64.patch b/extras/golang/0006-Default-to-ld.bfd-on-ARM64.patch new file mode 100644 index 0000000..369b4e6 --- /dev/null +++ b/extras/golang/0006-Default-to-ld.bfd-on-ARM64.patch @@ -0,0 +1,46 @@ +From 46ec67413008607e2150e3395668e54e538c5b6b Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Alejandro=20S=C3=A1ez?= +Date: Wed, 19 Jun 2024 10:18:58 +0200 +Subject: [PATCH] Default to ld.bfd on ARM64 + +--- + src/cmd/link/internal/ld/lib.go | 20 +++++++------------- + 1 file changed, 7 insertions(+), 13 deletions(-) + +diff --git a/src/cmd/link/internal/ld/lib.go b/src/cmd/link/internal/ld/lib.go +index eab74dc328..b401f58727 100644 +--- a/src/cmd/link/internal/ld/lib.go ++++ b/src/cmd/link/internal/ld/lib.go +@@ -1620,22 +1620,16 @@ func (ctxt *Link) hostlink() { + } + + if ctxt.Arch.InFamily(sys.ARM64) && buildcfg.GOOS == "linux" { +- // On ARM64, the GNU linker will fail with +- // -znocopyreloc if it thinks a COPY relocation is +- // required. Switch to gold. +- // https://sourceware.org/bugzilla/show_bug.cgi?id=19962 +- // https://go.dev/issue/22040 +- altLinker = "gold" +- +- // If gold is not installed, gcc will silently switch +- // back to ld.bfd. So we parse the version information +- // and provide a useful error if gold is missing. ++ // Use ld.bfd as the default linker ++ altLinker = "bfd" ++ ++ // Provide a useful error if ld.bfd is missing + name, args := flagExtld[0], flagExtld[1:] +- args = append(args, "-fuse-ld=gold", "-Wl,--version") ++ args = append(args, "-fuse-ld=bfd", "-Wl,--version") + cmd := exec.Command(name, args...) + if out, err := cmd.CombinedOutput(); err == nil { +- if !bytes.Contains(out, []byte("GNU gold")) { +- log.Fatalf("ARM64 external linker must be gold (issue #15696, 22040), but is not: %s", out) ++ if !bytes.Contains(out, []byte("GNU ld")) { ++ log.Fatalf("ARM64 external linker must be ld.bfd, but is not: %s", out) + } + } + } +-- +2.45.1 + diff --git a/extras/golang/fix_TestScript_list_std.patch b/extras/golang/fix_TestScript_list_std.patch deleted file mode 100644 index ade3711..0000000 --- a/extras/golang/fix_TestScript_list_std.patch +++ /dev/null @@ -1,13 +0,0 @@ -diff --git a/src/cmd/go/testdata/script/list_std.txt b/src/cmd/go/testdata/script/list_std.txt -index 6ab1bd1..4a00e43 100644 ---- a/src/cmd/go/testdata/script/list_std.txt -+++ b/src/cmd/go/testdata/script/list_std.txt -@@ -6,7 +6,7 @@ env GO111MODULE=off - # Listing GOROOT should only find standard packages. - cd $GOROOT/src - go list -f '{{if not .Standard}}{{.ImportPath}}{{end}}' ./... --! stdout . -+stdout _$GOROOT - - # Standard packages should include cmd, but not cmd/vendor. - go list ./... diff --git a/extras/golang/golang-gdbinit b/extras/golang/golang-gdbinit index 4ef690b..ecddca6 100644 --- a/extras/golang/golang-gdbinit +++ b/extras/golang/golang-gdbinit @@ -1 +1 @@ -add-auto-load-safe-path /usr/lib/golang/src/pkg/runtime/runtime-gdb.py +add-auto-load-safe-path /usr/lib/golang/src/runtime/runtime-gdb.py diff --git a/extras/golang/golang.spec b/extras/golang/golang.spec index 2c55d91..59fc261 100644 --- a/extras/golang/golang.spec +++ b/extras/golang/golang.spec @@ -1,6 +1,21 @@ -%undefine _missing_build_ids_terminate_build +## START: Set by rpmautospec +## (rpmautospec version 0.6.5) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 4; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec -%global bcond_with strict_fips +%bcond_with bootstrap +# temporalily ignore test failures +# due to https://github.com/golang/go/issues/39466 +%ifarch aarch64 +%bcond_without ignore_tests +%else +%bcond_with ignore_tests +%endif # build ids are not currently generated: # https://code.google.com/p/go/issues/detail?id=5238 @@ -26,56 +41,60 @@ %global __spec_install_post /usr/lib/rpm/check-rpaths /usr/lib/rpm/check-buildroot \ /usr/lib/rpm/brp-compress -# Define GOROOT macros -%global goroot %{_prefix}/lib/%{name} -%global gopath %{_datadir}/gocode -%global golang_arches x86_64 aarch64 ppc64le s390x -%global golibdir %{_libdir}/%{name} +%global golibdir %{_libdir}/golang + +# This macro may not always be defined, ensure it is +%{!?gopath: %global gopath %{_datadir}/gocode} # Golang build options. +# Disable FIPS by default +%global fips 0 +# Enable FIPS by default in RHEL +%if 0%{?rhel} +%global fips 1 +%endif + # Build golang using external/internal(close to cgo disabled) linking. -%ifarch x86_64 ppc64le %{arm} aarch64 s390x +%ifarch %{ix86} x86_64 ppc64le %{arm} aarch64 s390x %global external_linker 1 %else %global external_linker 0 %endif # Build golang with cgo enabled/disabled(later equals more or less to internal linking). -%ifarch x86_64 ppc64le %{arm} aarch64 s390x +%ifarch %{ix86} x86_64 ppc64le %{arm} aarch64 s390x %global cgo_enabled 1 %else %global cgo_enabled 0 %endif # Use golang/gcc-go as bootstrap compiler -%ifarch %{golang_arches} -%global golang_bootstrap 1 -%else +%if %{with bootstrap} %global golang_bootstrap 0 +%else +%global golang_bootstrap 1 %endif # Controls what ever we fail on failed tests -%ifarch x86_64 %{arm} ppc64le s390x -%global fail_on_tests 1 -%else +%if %{with ignore_tests} %global fail_on_tests 0 -%endif - -# Build golang shared objects for stdlib -%ifarch 0 -%global shared 1 %else -%global shared 0 +%global fail_on_tests 1 %endif -# Pre build std lib with -race enabled -# Disabled due to 1.20 new cache usage, see 1.20 upstream release notes -%global race 0 +# shared mode is breaks Go 1.21 in ELN +%global shared 0 + +# Fedora GOROOT +%global goroot /usr/lib/%{name} %ifarch x86_64 %global gohostarch amd64 %endif +%ifarch %{ix86} +%global gohostarch 386 +%endif %ifarch %{arm} %global gohostarch arm %endif @@ -92,59 +111,91 @@ %global gohostarch s390x %endif -%global go_api 1.22 -%global go_version 1.22.3 -%global version %{go_version} +%global go_api 1.23 +# Use only for prerelease versions +#global go_prerelease rc3 +%global go_patch 1 +%global go_version %{go_api}%{?go_patch:.%{go_patch}}%{?go_prerelease:~%{go_prerelease}} +%global go_source %{go_api}%{?go_patch:.%{go_patch}}%{?go_prerelease} +# Go FIPS package release %global pkg_release 1 +# For rpmdev-bumpspec and releng automation. +%global baserelease 1 + Name: golang -Version: %{version} -Release: 1%{?dist} +Version: %{go_version} +Release: %autorelease Summary: The Go Programming Language # source tree includes several copies of Mark.Twain-Tom.Sawyer.txt under Public Domain -License: BSD and Public Domain -URL: http://golang.org/ -Source0: https://github.com/golang/go/archive/refs/tags/go%{version}.tar.gz +License: BSD-3-Clause AND LicenseRef-Fedora-Public-Domain +URL: https://go.dev +Source0: https://go.dev/dl/go%{go_source}.src.tar.gz # Go's FIPS mode bindings are now provided as a standalone # module instead of in tree. This makes it easier to see # the actual changes vs upstream Go. The module source is # located at https://github.com/golang-fips/openssl-fips, # And pre-genetated patches to set up the module for a given # Go release are located at https://github.com/golang-fips/go. -Source1: https://github.com/golang-fips/go/archive/refs/tags/go%{version}-%{pkg_release}-openssl-fips.tar.gz +# making a source conditional creates odd behaviors so for now, include FIPS always +Source1: https://github.com/golang-fips/go/archive/refs/tags/go%{go_source}-%{pkg_release}-openssl-fips.tar.gz # make possible to override default traceback level at build time by setting build tag rpm_crashtraceback Source2: fedora.go # The compiler is written in Go. Needs go(1.4+) compiler for build. -# Actual Go based bootstrap compiler provided by above source. %if !%{golang_bootstrap} BuildRequires: gcc-go >= 5 %else -BuildRequires: golang +BuildRequires: golang > 1.4 %endif + +# Install hostname(1) or net-tools(1) depending on the OS version %if 0%{?rhel} > 6 || 0%{?fedora} > 0 BuildRequires: hostname %else BuildRequires: net-tools %endif -# For OpenSSL FIPS + +# If FIPS is enabled, we need openssl-devel +%if %{fips} BuildRequires: openssl-devel -# for tests -BuildRequires: pcre-devel, glibc-static, perl +Requires: openssl-devel +%endif + +BuildRequires: glibc-static + +# For running the tests on Fedora +%if 0%{?fedora} +BuildRequires: perl-interpreter, procps-ng +%endif + +# For running the tests on RHEL +%if 0%{?rhel} +BuildRequires: perl +%endif Provides: go = %{version}-%{release} + +%if 0%{?fedora} +# Bundled/Vendored provides generated by bundled-deps.sh based on the in tree module data +Provides: bundled(golang(github.com/google/pprof)) = 0.0.0.20221118152302.e6195bd50e26 +Provides: bundled(golang(github.com/ianlancetaylor/demangle)) = 0.0.0.20220319035150.800ac71e25c2 +Provides: bundled(golang(golang.org/x/arch)) = 0.4.0 +Provides: bundled(golang(golang.org/x/crypto)) = 0.11.1.0.20230711161743.2e82bdd1719d +Provides: bundled(golang(golang.org/x/mod)) = 0.12.0 +Provides: bundled(golang(golang.org/x/net)) = 0.12.1.0.20230712162946.57553cbff163 +Provides: bundled(golang(golang.org/x/sync)) = 0.3.0 +Provides: bundled(golang(golang.org/x/sys)) = 0.10.0 +Provides: bundled(golang(golang.org/x/term)) = 0.10.0 +Provides: bundled(golang(golang.org/x/text)) = 0.11.0 +Provides: bundled(golang(golang.org/x/tools)) = 0.11.1.0.20230712164437.1ca21856af7b +%endif + Requires: %{name}-bin = %{version}-%{release} Requires: %{name}-src = %{version}-%{release} -Requires: openssl-devel -Requires: diffutils -# Proposed patch by jcajka https://golang.org/cl/86541 -Patch221: fix_TestScript_list_std.patch - -Patch1939923: skip_test_rhbz1939923.patch - -Patch4: modify_go.env.patch -Patch6: skip_TestCrashDumpsAllThreads.patch +Patch1: 0001-Modify-go.env.patch +Patch6: 0006-Default-to-ld.bfd-on-ARM64.patch # Having documentation separate was broken Obsoletes: %{name}-docs < 1.1-4 @@ -152,8 +203,9 @@ Obsoletes: %{name}-docs < 1.1-4 # RPM can't handle symlink -> dir with subpackages, so merge back Obsoletes: %{name}-data < 1.1.1-4 -# We don't build golang-race anymore, rhbz#2230705 -Obsoletes: golang-race < 1.20.0 +# go1.4 deprecates a few packages +Obsoletes: %{name}-vim < 1.4 +Obsoletes: emacs-%{name} < 1.4 # These are the only RHEL/Fedora architectures that we compile this package for ExclusiveArch: %{golang_arches} @@ -192,18 +244,54 @@ BuildArch: noarch %package src Summary: Golang compiler source tree BuildArch: noarch - %description src %{summary} %package bin Summary: Golang core compiler tools -Requires: %{name} = %{version}-%{release} +# Some distributions refer to this package by this name +Provides: %{name}-go = %{version}-%{release} +Requires: go = %{version}-%{release} +# Pre-go1.5, all arches had to be bootstrapped individually, before usable, and +# env variables to compile for the target os-arch. +# Now the host compiler needs only the GOOS and GOARCH environment variables +# set to compile for the target os-arch. +Obsoletes: %{name}-pkg-bin-linux-386 < 1.4.99 +Obsoletes: %{name}-pkg-bin-linux-amd64 < 1.4.99 +Obsoletes: %{name}-pkg-bin-linux-arm < 1.4.99 +Obsoletes: %{name}-pkg-linux-386 < 1.4.99 +Obsoletes: %{name}-pkg-linux-amd64 < 1.4.99 +Obsoletes: %{name}-pkg-linux-arm < 1.4.99 +Obsoletes: %{name}-pkg-darwin-386 < 1.4.99 +Obsoletes: %{name}-pkg-darwin-amd64 < 1.4.99 +Obsoletes: %{name}-pkg-windows-386 < 1.4.99 +Obsoletes: %{name}-pkg-windows-amd64 < 1.4.99 +Obsoletes: %{name}-pkg-plan9-386 < 1.4.99 +Obsoletes: %{name}-pkg-plan9-amd64 < 1.4.99 +Obsoletes: %{name}-pkg-freebsd-386 < 1.4.99 +Obsoletes: %{name}-pkg-freebsd-amd64 < 1.4.99 +Obsoletes: %{name}-pkg-freebsd-arm < 1.4.99 +Obsoletes: %{name}-pkg-netbsd-386 < 1.4.99 +Obsoletes: %{name}-pkg-netbsd-amd64 < 1.4.99 +Obsoletes: %{name}-pkg-netbsd-arm < 1.4.99 +Obsoletes: %{name}-pkg-openbsd-386 < 1.4.99 +Obsoletes: %{name}-pkg-openbsd-amd64 < 1.4.99 + +Obsoletes: golang-vet < 0-12.1 +Obsoletes: golang-cover < 0-12.1 + +Requires(post): %{_sbindir}/update-alternatives +Requires(preun): %{_sbindir}/update-alternatives # We strip the meta dependency, but go does require glibc. # This is an odd issue, still looking for a better fix. Requires: glibc -Requires: /usr/bin/gcc +Requires: gcc +%if 0%{?rhel} && 0%{?rhel} < 8 +Requires: git, subversion, mercurial +%else +Recommends: git, subversion, mercurial +%endif %description bin %{summary} @@ -225,20 +313,10 @@ Summary: Golang shared object libraries %{summary}. %endif -%if %{race} -%package race -Summary: Golang std library with -race enabled - -Requires: %{name} = %{version}-%{release} - -%description race -%{summary} -%endif - %package -n go-toolset Summary: Package that installs go-toolset Requires: %{name} = %{version}-%{release} -%ifarch x86_64 aarch64 ppc64le +%ifarch x86_64 aarch64 Requires: delve %endif @@ -246,32 +324,41 @@ Requires: delve This is the main package for go-toolset. %prep -%setup -q -n go-go%{version} +%autosetup -p1 -n go +# Copy fedora.go to ./src/runtime/ +cp %{SOURCE2} ./src/runtime/ +sed -i '1s/$/ (%{?rhel:Red Hat} %{version}-%{release})/' VERSION +# Delete the boring binary blob. We use the system OpenSSL instead. +rm -rf src/crypto/internal/boring/syso -pushd .. -tar -xf %{SOURCE1} -popd -patch_dir="../go-go%{version}-%{pkg_release}-openssl-fips/patches" -# Add --no-backup-if-mismatch option to avoid creating .orig temp files -for p in "$patch_dir"/*.patch; do +# If FIPS is enabled, install the FIPS source +%if %{fips} + echo "Preparing FIPS patches" + pushd .. + tar -xf %{SOURCE1} + popd + # TODO Check here, this is failing due to the external linker flag? maybe, but it's clearly related to that according tho this commit: + # https://github.com/golang-fips/go/blob/main/patches/000-initial-setup.patch#L48 + # Add --no-backup-if-mismatch option to avoid creating .orig temp files + patch_dir="../go-go%{version}-%{pkg_release}-openssl-fips/patches" + for p in "$patch_dir"/*.patch; do echo "Applying $p" patch --no-backup-if-mismatch -p1 < $p -done + done -# Configure crypto tests -pushd ../go-go%{version}-%{pkg_release}-openssl-fips -ln -s ../go-go%{version} go -./scripts/configure-crypto-tests.sh -popd - -%autopatch -p1 - -sed -i '1s/$/ (%{?rhel:Red Hat} %{version}-%{release})/' VERSION - -cp %{SOURCE2} ./src/runtime/ + # Configure crypto tests + echo "Configure crypto tests" + pushd ../go-go%{version}-%{pkg_release}-openssl-fips + ln -s ../go go + ./scripts/configure-crypto-tests.sh + popd +%endif %build +# -x: print commands as they are executed +# -e: exit immediately if a command exits with a non-zero status set -xe + # print out system information uname -a cat /proc/cpuinfo @@ -281,7 +368,7 @@ cat /proc/meminfo %if !%{golang_bootstrap} export GOROOT_BOOTSTRAP=/ %else -export GOROOT_BOOTSTRAP=/opt/rh/go-toolset-1.10/root/usr/lib/go-toolset-1.10-golang +export GOROOT_BOOTSTRAP=%{goroot} %endif # set up final install location @@ -298,6 +385,7 @@ export CC="gcc" export CC_FOR_TARGET="gcc" export GOOS=linux export GOARCH=%{gohostarch} +export GOAMD64=v2 DEFAULT_GO_LD_FLAGS="" %if !%{external_linker} @@ -308,35 +396,28 @@ export GO_LDFLAGS="-linkmode internal $DEFAULT_GO_LD_FLAGS" # building in PIE mode. export GO_LDFLAGS="\"-extldflags=-Wl,-z,now,-z,relro\" $DEFAULT_GO_LD_FLAGS" %endif + %if !%{cgo_enabled} export CGO_ENABLED=0 -%else -export CGO_CFLAGS="$CGO_CFLAGS -I%{_includedir}/openssl3" %endif -./make.bash --no-clean + +./make.bash --no-clean -v popd # build shared std lib %if %{shared} -GOROOT=$(pwd) PATH=$(pwd)/bin:$PATH go install -buildmode=shared std +GOROOT=$(pwd) PATH=$(pwd)/bin:$PATH go install -buildmode=shared -v -x std %endif -%if %{race} -GOROOT=$(pwd) PATH=$(pwd)/bin:$PATH go install -race std -%endif - - %install - rm -rf $RPM_BUILD_ROOT +# remove GC build cache +rm -rf pkg/obj/go-build/* # create the top level directories mkdir -p $RPM_BUILD_ROOT%{_bindir} mkdir -p $RPM_BUILD_ROOT%{goroot} -# remove bootstrap binaries -rm -rf pkg/bootstrap/bin - # install everything into libdir (until symlink problems are fixed) # https://code.google.com/p/go/issues/detail?id=5830 cp -apv api bin doc lib pkg src misc test go.env VERSION \ @@ -352,14 +433,19 @@ cwd=$(pwd) src_list=$cwd/go-src.list pkg_list=$cwd/go-pkg.list shared_list=$cwd/go-shared.list +race_list=$cwd/go-race.list misc_list=$cwd/go-misc.list docs_list=$cwd/go-docs.list tests_list=$cwd/go-tests.list -rm -f $src_list $pkg_list $docs_list $misc_list $tests_list $shared_list -touch $src_list $pkg_list $docs_list $misc_list $tests_list $shared_list +rm -f $src_list $pkg_list $docs_list $misc_list $tests_list $shared_list $race_list +touch $src_list $pkg_list $docs_list $misc_list $tests_list $shared_list $race_list + +################## +# Register files # +################## pushd $RPM_BUILD_ROOT%{goroot} find src/ -type d -a \( ! -name testdata -a ! -ipath '*/testdata/*' \) -printf '%%%dir %{goroot}/%p\n' >> $src_list - find src/ ! -type d -a \( ! -ipath '*/testdata/*' -a ! -name '*_test*.go' \) -printf '%{goroot}/%p\n' >> $src_list + find src/ ! -type d -a \( ! -ipath '*/testdata/*' -a ! -name '*_test.go' \) -printf '%{goroot}/%p\n' >> $src_list find bin/ pkg/ -type d -a ! -path '*_dynlink/*' -a ! -path '*_race/*' -printf '%%%dir %{goroot}/%p\n' >> $pkg_list find bin/ pkg/ ! -type d -a ! -path '*_dynlink/*' -a ! -path '*_race/*' -printf '%{goroot}/%p\n' >> $pkg_list @@ -386,24 +472,22 @@ pushd $RPM_BUILD_ROOT%{goroot} find pkg/*_dynlink/ -type d -printf '%%%dir %{goroot}/%p\n' >> $shared_list find pkg/*_dynlink/ ! -type d -printf '%{goroot}/%p\n' >> $shared_list %endif - find test/ -type d -printf '%%%dir %{goroot}/%p\n' >> $tests_list find test/ ! -type d -printf '%{goroot}/%p\n' >> $tests_list find src/ -type d -a \( -name testdata -o -ipath '*/testdata/*' \) -printf '%%%dir %{goroot}/%p\n' >> $tests_list - find src/ ! -type d -a \( -ipath '*/testdata/*' -o -name '*_test*.go' \) -printf '%{goroot}/%p\n' >> $tests_list + find src/ ! -type d -a \( -ipath '*/testdata/*' -o -name '*_test.go' \) -printf '%{goroot}/%p\n' >> $tests_list # this is only the zoneinfo.zip find lib/ -type d -printf '%%%dir %{goroot}/%p\n' >> $tests_list find lib/ ! -type d -printf '%{goroot}/%p\n' >> $tests_list popd - # remove the doc Makefile rm -rfv $RPM_BUILD_ROOT%{goroot}/doc/Makefile # put binaries to bindir, linked to the arch we're building, # leave the arch independent pieces in {goroot} mkdir -p $RPM_BUILD_ROOT%{goroot}/bin/linux_%{gohostarch} -ln -sf %{goroot}/bin/go $RPM_BUILD_ROOT%{_bindir}/go -ln -sf %{goroot}/bin/gofmt $RPM_BUILD_ROOT%{_bindir}/gofmt +ln -sf %{goroot}/bin/go $RPM_BUILD_ROOT%{goroot}/bin/linux_%{gohostarch}/go +ln -sf %{goroot}/bin/gofmt $RPM_BUILD_ROOT%{goroot}/bin/linux_%{gohostarch}/gofmt # ensure these exist and are owned mkdir -p $RPM_BUILD_ROOT%{gopath}/src/github.com @@ -411,6 +495,12 @@ mkdir -p $RPM_BUILD_ROOT%{gopath}/src/bitbucket.org mkdir -p $RPM_BUILD_ROOT%{gopath}/src/code.google.com/p mkdir -p $RPM_BUILD_ROOT%{gopath}/src/golang.org/x +# make sure these files exist and point to alternatives +rm -f $RPM_BUILD_ROOT%{_bindir}/go +ln -sf /etc/alternatives/go $RPM_BUILD_ROOT%{_bindir}/go +rm -f $RPM_BUILD_ROOT%{_bindir}/gofmt +ln -sf /etc/alternatives/gofmt $RPM_BUILD_ROOT%{_bindir}/gofmt + # gdbinit mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/gdbinit.d cp -av %{SOURCE100} $RPM_BUILD_ROOT%{_sysconfdir}/gdbinit.d/golang.gdb @@ -419,8 +509,10 @@ cp -av %{SOURCE100} $RPM_BUILD_ROOT%{_sysconfdir}/gdbinit.d/golang.gdb mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/prelink.conf.d cp -av %{SOURCE101} $RPM_BUILD_ROOT%{_sysconfdir}/prelink.conf.d/golang.conf +%if %{fips} # Quick fix for the rhbz#2014704 sed -i 's/const defaultGO_LDSO = `.*`/const defaultGO_LDSO = ``/' $RPM_BUILD_ROOT%{goroot}/src/internal/buildcfg/zbootstrap.go +%endif %check export GOROOT=$(pwd -P) @@ -454,45 +546,57 @@ export GO_TEST_RUN="" export GO_TEST_RUN="-run=!testshared" %endif +echo "=== Start testing ===" %if %{fail_on_tests} + ./run.bash --no-rebuild -v -v -v -k $GO_TEST_RUN + %if %{fips} + echo "=== Running FIPS tests ===" + # tested25519vectors needs network connectivity but it should be cover by + # this test https://pkgs.devel.redhat.com/cgit/tests/golang/tree/regression/internal-testsuite/runtest.sh#n127 -./run.bash --no-rebuild -v -v -v -k $GO_TEST_RUN - -# Run tests with FIPS enabled. -export GOLANG_FIPS=1 -export OPENSSL_FORCE_FIPS_MODE=1 -pushd crypto - # Run all crypto tests but skip TLS, we will run FIPS specific TLS tests later - go test -timeout 50m $(go list ./... | grep -v tls) -v - # Check that signature functions have parity between boring and notboring - CGO_ENABLED=0 go test -timeout 50m $(go list ./... | grep -v tls) -v -popd -# Run all FIPS specific TLS tests -pushd crypto/tls - go test -v -run "Boring" -popd + # run tests with fips enabled. + export GOLANG_FIPS=1 + export OPENSSL_FORCE_FIPS_MODE=1 + echo "=== Run all crypto test skipping tls ===" + pushd crypto + # run all crypto tests but skip tls, we will run fips specific tls tests later + go test $(go list ./... | grep -v tls) -v + # check that signature functions have parity between boring and notboring + CGO_ENABLED=0 go test $(go list ./... | grep -v tls) -v + popd + echo "=== Run tls tests ===" + # run all fips specific tls tests + pushd crypto/tls + go test -v -run "Boring" + popd + %endif %else -./run.bash --no-rebuild -v -v -v -k || : + ./run.bash --no-rebuild -v -v -v -k || : %endif +echo "=== End testing ===" cd .. -%files +%post bin +%{_sbindir}/update-alternatives --install %{_bindir}/go \ + go %{goroot}/bin/go 90 \ + --slave %{_bindir}/gofmt gofmt %{goroot}/bin/gofmt -%doc LICENSE PATENTS +%preun bin +if [ $1 = 0 ]; then + %{_sbindir}/update-alternatives --remove go %{goroot}/bin/go +fi + + +%files +%license LICENSE PATENTS # VERSION has to be present in the GOROOT, for `go install std` to work %doc %{goroot}/VERSION %dir %{goroot}/doc -%doc %{goroot}/doc/* # go files %dir %{goroot} -%exclude %{goroot}/bin/ -%exclude %{goroot}/pkg/ -%exclude %{goroot}/src/ -%exclude %{goroot}/doc/ -%exclude %{goroot}/misc/ -%exclude %{goroot}/test/ -%{goroot}/* +%{goroot}/api/ +%{goroot}/lib/time/ # ensure directory ownership, so they are cleaned up if empty %dir %{gopath} @@ -510,466 +614,603 @@ cd .. # prelink blacklist %{_sysconfdir}/prelink.conf.d +%files src -f go-src.list -%files -f go-src.list src +%files docs -f go-docs.list -%files -f go-docs.list docs +%files misc -f go-misc.list -%files -f go-misc.list misc +%files tests -f go-tests.list -%files -f go-tests.list tests - -%files -f go-pkg.list bin +%files bin -f go-pkg.list %{_bindir}/go %{_bindir}/gofmt %{goroot}/go.env +%{goroot}/bin/linux_%{gohostarch}/go +%{goroot}/bin/linux_%{gohostarch}/gofmt %if %{shared} -%files -f go-shared.list shared +%files shared -f go-shared.list %endif %files -n go-toolset %changelog +## START: Generated by rpmautospec +* Fri Nov 29 2024 Alejandro Sáez - 1.23.1-4 +- Remove bundled boringcrypto blob + +* Tue Oct 29 2024 Troy Dawson - 1.23.1-3 +- Bump release for October 2024 mass rebuild: + +* Wed Sep 25 2024 Derek Parker - 1.23.1-2 +- Update baserelease + +* Tue Sep 24 2024 Derek Parker - 1.23.1-1 +- Rebase to 1.23.1 + +* Thu Aug 29 2024 Archana - 1.22.5-3 +- Include fix that loads Openssl only in FIPS mode - Resolves: RHEL-52486 + +* Tue Jul 16 2024 Alejandro Sáez - 1.22.5-2 +- Default to ld.bfd on ARM64 + +* Thu Jul 11 2024 Archana - 1.22.5-1 +- Rebase to Go1.22.5 to address CVE-2024-24791 - Resolves: RHEL-46971 + +* Mon Jun 24 2024 Troy Dawson - 1.22.4-2 +- Bump release for June 2024 mass rebuild + +* Thu Jun 06 2024 Archana - 1.22.4-1 +- Rebase to Go1.22.4 - Resolves: RHEL-40155 + +* Wed Jun 05 2024 Alejandro Sáez - 1.22.3-4 +- Update RHEL10 go.env to use power9 ISA on PPC64LE + +* Thu May 30 2024 Derek Parker - 1.22.3-3 +- Update openssl backend + +* Fri May 24 2024 Derek Parker - 1.22.3-2 +- Restore HashSign / HashVerify API + * Wed May 22 2024 Alejandro Sáez - 1.22.3-1 -- Rebase to 1.22.3 -- Removes re-enable-cgo.patch -- Resolves: RHEL-35634 -- Resolves: RHEL-35883 -- Resolves: RHEL-10068 -- Resolves: RHEL-34924 +- Update to Go 1.22.3 -* Thu Apr 18 2024 Derek Parker - 1.22.2-1 -- Rebase to 1.22.2 -- Resolves: RHEL-28941 +* Fri May 17 2024 Alejandro Sáez - 1.22.2-8 +- Renaming patch -* Tue Apr 09 2024 Alejandro Sáez - 1.22.1-2 -- Set the AMD64 baseline to v2 +* Tue May 14 2024 Alejandro Sáez - 1.22.2-7 +- Add RHEL version to the go version command -* Tue Mar 19 2024 Alejandro Sáez - 1.22.1-1 -- Rebase to Go 1.22.1 -- Re-enable CGO -- Resolves: RHEL-29527 -- Resolves: RHEL-28175 +* Tue May 14 2024 Archana - 1.22.2-6 +- Corrected golang.spec to use --no-backup-if-mismatch to avoid creating + .orig files - Resolves: RHEL-34671 -* Fri Feb 09 2024 Alejandro Sáez - 1.21.7-1 -- Rebase to Go 1.21.7 -- Set GOTOOLCHAIN to local -- Resolves: RHEL-24334 -- Resolves: RHEL-18364 -- Resolves: RHEL-18365 +* Fri May 10 2024 Edjunior Machado - 1.22.2-5 +- Add rpminspect.yaml -* Thu Nov 30 2023 Alejandro Sáez - 1.21.4-2 -- Add release information +* Fri May 10 2024 Alejandro Sáez - 1.22.2-4 +- Include go.env in the root -* Tue Nov 14 2023 Alejandro Sáez - 1.21.4-1 -- Rebase to Go 1.21.4 -- Resolves: RHEL-11871 +* Fri May 10 2024 Edjunior Machado - 1.22.2-3 +- gating.yaml: Add gating config for rhel-10 -* Wed Nov 08 2023 David Benoit - 1.21.3-5 -- Don't change GOPROXY/GOSUMDB -- Related: RHEL-12624 +* Wed May 08 2024 Archana - 1.22.2-2 +- Modified golang.spec to delete intermediate .orig files that create + issues in the build - Resolves: RHEL-34671 -* Thu Nov 02 2023 David Benoit - 1.21.3-4 -- Fix missing go.env in Go 1.21 -- Related: RHEL-12624 +* Mon Apr 22 2024 Archana - 1.22.2-1 +- Updated Go version to 1.22.2 - Resolves: RHEL-29526 -* Tue Oct 31 2023 Archana Ravindar - 1.21.3-3 -- Add missing strict fips runtime detection patch -- Temporarily disable FIPS tests on aarch64 due to builder kernel bugs -- Related: RHEL-12624 +* Fri Apr 12 2024 Alejandro Sáez - 1.22.1-4 +- Set the baselines for AMD64 and PPC64LE -* Wed Oct 25 2023 Archana Ravindar - 1.21.3-2 -- Rebase disable_static_tests_part2.patch to Go 1.21.3 -- Related: RHEL-12624 +* Mon Apr 08 2024 Archana - 1.22.1-3 +- Fix mockbuild error: Had missed running centpkg new-sources - Resolves: + RHEL-29526 -* Fri Oct 20 2023 Archana Ravindar - 1.21.3-1 -- Rebase to Go 1.21.3 -- Resolves: RHEL-12624 +* Mon Apr 01 2024 Archana - 1.22.1-2 +- Bumped pkg_release to 2 - Rebase to Go1.22.1 - Resolves RHEL-29526 -* Wed Sep 27 2023 Alejandro Sáez - 1.20.8-1 -- Rebase to Go 1.20.8 -- Remove fix-memory-leak-evp-sign-verify.patch as it is already included in the source -- Resolves: RHEL-2775 +* Mon Mar 25 2024 Archana - 1.22.1-1 +- Rebase to Go1.22.1 - Resolves RHEL-29526 -* Mon Aug 14 2023 Alejandro Sáez - 1.20.6-5 -- Retire golang-race package -- Resolves: rhbz#2230705 +* Thu Nov 09 2023 Alejandro Sáez - 1.21.3-4 +- Add indications in the tests -* Tue Jul 18 2023 Alejandro Sáez - 1.20.6-1 -- Rebase to Go 1.20.6 -- Change to autopatch -- Resolves: rhbz#2222313 +* Thu Sep 28 2023 Alejandro Sáez - 1.20.6-3 +- Migrated to SPDX license -* Fri Jun 23 2023 Alejandro Sáez - 1.20.4-3 -- Increase the timeout in the tests -- Related: rhbz#2204477 +* Tue Sep 05 2023 Yaakov Selkowitz - 1.20.6-2 +- Drop unused pcre dependency -* Fri Jun 09 2023 Carl George - 1.20.4-2 -- Add go-toolset subpackage to ensure golang and go-toolset are published together -- Resolves: rhbz#2117248 +* Tue Aug 01 2023 Alejandro Sáez - 1.20.6-1 +- Update to go 1.20.6 -* Mon May 29 2023 Alejandro Sáez - 1.20.4-1 -- Rebase to Go 1.20.4 -- Resolves: rhbz#2204477 +* Wed Jun 28 2023 Yaakov Selkowitz - 1.20.5-4 +- Add go-toolset subpackage -* Tue Apr 11 2023 David Benoit - 1.20.3-1 -- Rebase to Go 1.20.3 -- Remove race archives -- Update static test patches -- Resolves: rhbz#2185259 +* Thu Jun 22 2023 Yaakov Selkowitz - 1.20.5-3 +- Add runtime requirement for openssl-devel -* Wed Mar 01 2023 David Benoit - 1.19.6-1 -- Rebase to Go 1.19.6 -- Resolves: rhbz#2174429 -- Fix memory leak -- Resolves: rhbz#2157602 -- Enable tests in check phase +* Wed Jun 14 2023 Alejandro Sáez - 1.20.5-2 +- Package bump up do to a mistake I made -* Wed Dec 21 2022 David Benoit - 1.19.4-1 -- Rebase to Go 1.19.4 -- Fix ppc64le linker issue -- Remove defunct patches -- Remove downstream generated FIPS mode patches -- Add golang-fips/go as the source for FIPS mode patches -- Resolves: rhbz#2144539 +* Wed Jun 14 2023 Alejandro Sáez - 1.20.5-1 +- Update to go1.20.5 -* Wed Nov 30 2022 David Benoit - 1.19.2-2 -- Fix endian issue in FIPS mode -- Resolves: rhbz#1966992 +* Tue Jun 13 2023 Alejandro Sáez - 1.20.4-3 +- Add FIPS support for RHEL targets -* Fri Oct 21 2022 David Benoit - 1.19.2-1 -- Update go to version 1.19.2 -- Resolves: rhbz#2134407 +* Tue May 02 2023 Alejandro Sáez - 1.20.4-1 +- Update to go1.20.4 +- Resolves: rhbz#2184454 -* Wed Sep 14 2022 David Benoit - 1.19.1-2 -- Rebase to Go 1.19.1 -- Temporarily disable crypto tests -- Resolves: rhbz#2131028 +* Sat Apr 15 2023 Maxwell G - 1.20.3-2 +- Fix broken golang-race update path -* Wed Aug 10 2022 Alejandro Sáez - 1.18.4-2 -- Update to Go 1.18.4 -- Resolves: rhbz#2109180 -- Deprecates keys smaller than 2048 bits in TestDecryptOAEP in boring mode +* Tue Apr 04 2023 Alejandro Sáez - 1.20.3-1 +- Update to go1.20.3 -* Fri Aug 05 2022 Alejandro Sáez - 1.18.4-1 -- Update to Go 1.18.4 -- Resolves: rhbz#2109180 +* Fri Mar 10 2023 Mike Rochefort - 1.20.2-1 +- Update to go1.20.2 +- Resolves: rhbz#2176528 -* Fri Jun 10 2022 David Benoit - 1.18.2-2 -- Update deprecated openssl algorithms patch -- Rebuild against openssl-3.0.1-33 -- Resolves: rhbz#2092136 -- Related: rhbz#2092016 +* Wed Feb 15 2023 Alejandro Sáez - 1.20.1 +- Update to go1.20.1 +- Resolves: rhbz#2169896 -* Mon May 02 2022 David Benoit - 1.18.2-1 -- Rebase to Go 1.18.2 -- Move to github.com/golang-fips/go -- Resolves: rhbz#2075169 -- Resolves: rhbz#2060769 -- Resolves: rhbz#2067531 -- Resolves: rhbz#2067536 -- Resolves: rhbz#2067552 -- Resolves: rhbz#2025637 +* Thu Feb 02 2023 Alejandro Sáez - 1.20-1 +- Update to go1.20 +- Resolves: rhbz#2152070 -* Mon Dec 13 2021 Alejandro Sáez - 1.17.5-1 -- Rebase to Go 1.17.5 -- Add remove_waitgroup_misuse_tests patch -- Add remove_ed25519vectors_test.patch -- Remove FIPS checks to avoid issues in the CI -- Related: rhbz#2031116 -- Resolves: rhbz#2022829 -- Resolves: rhbz#2024687 -- Resolves: rhbz#2030851 -- Resolves: rhbz#2031253 +* Thu Jan 19 2023 Fedora Release Engineering - 1.20~rc3-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild -* Wed Nov 03 2021 Alejandro Sáez - 1.17.2-1 -- Rebase to Go 1.17.2 -- Related: rhbz#2014087 -- Remove favicon.ico and robots.txt references -- Exclude TestEd25519Vectors test -- Update patch rhbz1952381 -- Remove rhbz1904567 patch -- Remove rhbz1939923 patch +* Tue Jan 17 2023 Alejandro Sáez - 1.20~rc3-1 +- Update to go1.20rc3 +- Disable race package due go 1.20 new feature -* Mon Aug 09 2021 Mohan Boddu - 1.16.6-4 -- Rebuilt for IMA sigs, glibc 2.34, aarch64 flags - Related: rhbz#1991688 +* Wed Jan 04 2023 Alejandro Sáez - 1.20-0.rc2-1 +- Update to go1.20rc2 -* Wed Aug 4 2021 Derek Parker - 1.16.6-3 -- Include ppc64le VDSO segfault backport fix -- Resolves: rhbz#1966622 +* Wed Dec 07 2022 Alejandro Sáez - 1.19.4-1 +- Update to go1.19.4 +- Resolves: rhbz#2151595 -* Mon Aug 2 2021 Derek Parker - 1.16.6-2 -- Bump release -- Resolves: rhbz#1904567 +* Tue Nov 8 2022 Amit Shah - 1.19.3-2 +- Fix build without binutils-gold -* Mon Aug 2 2021 Derek Parker - 1.16.6-2 -- Backport fix allowing LTO to be enabled on cgo sources -- Resolves: rhbz#1904567 +* Sun Nov 06 2022 Mike Rochefort - 1.19.3-1 +- Update to go1.19.3 +- Resolves: rhbz#2139548 -* Tue Jul 20 2021 Derek Parker - 1.16.6-1 -- Rebase to 1.16.6 -- Resolves: rhbz#1984124 -- Replace symbols no longer present in OpenSSL 3.0 ABI -- Resolves: rhbz#1984110 -- Fix TestBoringServerCurves failing when ran by itself -- Resolves: rhbz#1977914 +* Tue Oct 04 2022 Alejandro Sáez - 1.19.2-1 +- Update to go1.19.2 -* Tue Jun 22 2021 Mohan Boddu - 1.16.4-3 -- Rebuilt for RHEL 9 BETA for openssl 3.0 - Related: rhbz#1971065 +* Tue Sep 06 2022 Alejandro Sáez - 1.19.1-1 +- Update to go1.19.1 -* Fri May 28 2021 David Benoit - 1.16.4-2 -- Port to OpenSSL 3.0 -- Resolves: rhbz#1952381 +* Tue Aug 02 2022 Alejandro Sáez - 1.19-1 +- Update to go1.19.0 +- Remove reference to AUTHORS and CONTRIBUTORS due to https://github.com/golang/go/issues/53961 -* Fri May 14 2021 Alejandro Sáez - 1.16.4-1 -- Rebase to 1.16.4 -- Resolves: rhbz#1955035 -- Resolves: rhbz#1957961 +* Thu Jul 21 2022 Fedora Release Engineering - 1.19~rc2-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild -* Thu Apr 15 2021 Mohan Boddu - 1.16.1-3 -- Rebuilt for RHEL 9 BETA on Apr 15th 2021. Related: rhbz#1947937 +* Mon Jul 18 2022 Mike Rochefort - 1.19~rc2-1 +- Update to go1.19rc2 +- Remove tzdata patch +- Remove go-srpm-macros runtime requirement +- Resolves: rhbz#2095927 -* Tue Mar 30 2021 Alejandro Sáez - 1.16.1-2 -- Rebase to go-1.16.1-2-openssl-fips -- Resolves: rhbz#1922455 +* Wed Jul 13 2022 Alejandro Sáez - 1.18.4-1 +- Update to 1.18.4 -* Tue Mar 30 2021 Alejandro Sáez - 1.16.1-1 -- Rebase to go-1.16.1-2-openssl-fips -- Adds a workaround for rhbz#1939923 -- Removes Patch224, it's on upstream -> rhbz#1888673 -- Removes Patch225, it's on upstream -> https://go-review.googlesource.com/c/text/+/238238 -- Removes old patches for cleaning purposes -- Related: rhbz#1942898 +* Sun Jun 19 2022 Robert-André Mauchin - 1.18.3-2 +- Rebuilt for CVE-2022-1996, CVE-2022-24675, CVE-2022-28327, CVE-2022-27191, + CVE-2022-29526, CVE-2022-30629 -* Fri Jan 22 2021 David Benoit - 1.15.7-1 -- Rebase to 1.15.7 -- Resolves: rhbz#1892207 -- Resolves: rhbz#1918755 +* Thu Jun 02 2022 Alejandro Sáez - 1.18.3-1 +- Update to 1.18.3 +- Resolves: rhbz#2092631 -* Tue Nov 24 2020 David Benoit - 1.15.5-1 -- Rebase to 1.15.5 -- Resolves: rhbz#1899184 -- Resolves: rhbz#1899185 -- Resolves: rhbz#1899186 +* Sun May 15 2022 Mike Rochefort - 1.18.2-1 +- Update to 1.18.2 +- Resolves: rhbz#2075141 -* Thu Nov 12 2020 David Benoit - 1.15.3-2 -- Rebase to 1.15.3 -- fix x/text infinite loop -- Resolves: rhbz#1881539 +* Tue Apr 12 2022 Alejandro Sáez - 1.18.1-1 +- Update to 1.18.1 -* Tue Nov 03 2020 Alejandro Sáez - 1.15.2-2 -- Resolves: rhbz#1850045 +* Tue Mar 15 2022 Mike Rochefort - 1.18-1 +- Update to 1.18 +- Resolves: rhbz#2064409 -* Mon Oct 19 2020 David Benoit - 1.15.2-1 -- Rebase to 1.15.2 -- fix rhbz#1872622 in commit af9a1b1f6567a1c5273a134d395bfe7bb840b7f8 -- Resolves: rhbz#1872622 -- add net/http graceful shutdown patch -- Resolves: rhbz#1888673 -- add x509warnCN patch -- Resolves: rhbz#1889437 +* Thu Feb 17 2022 Mike Rochefort - 1.18~rc1-1 +- Update to 1.18rc1 +- Resolves: rhbz#2002859 -* Wed Sep 09 2020 Alejandro Sáez - 1.15.0-1 -- Rebase to 1.15.0 -- Related: rhbz#1870531 +* Mon Jan 31 2022 Mike Rochefort - 1.18~beta2-1 +- Update to 1.18beta2 +- Remove testshared-size-limit patch (now upstream) 83fc097 +- Related: rhbz#2002859 -* Thu Aug 27 2020 Alejandro Sáez - 1.14.7-2 -- Improve test suite -- Resolves: rhbz#1854693 +* Thu Jan 20 2022 Fedora Release Engineering - 1.18~beta1-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild -* Tue Aug 18 2020 Alejandro Sáez - 1.14.7-1 -- Rebase to 1.14.7 +* Tue Dec 14 2021 Mike Rochefort - 1.18beta1-1 +- Update to 1.18beta1 +- Related: rhbz#2002859 -* Mon Aug 03 2020 Alejandro Sáez - 1.14.6-1 -- Rebase to 1.14.6 -- Resolves: rhbz#1820596 +* Tue Dec 14 2021 Alejandro Sáez - 1.17.5-1 +- Update to 1.17.5 +- Update bundles +- Related: rhbz#2002859 -* Wed Jul 08 2020 Alejandro Sáez - 1.14.4-2 -- Include patch to fix missing deferreturn on linux/ppc64le -- Resolves: rhbz#1854836 +* Tue Dec 07 2021 Alejandro Sáez - 1.17.4-1 +- Update to 1.17.4 +- Related: rhbz#2002859 -* Thu Jun 25 2020 Alejandro Sáez - 1.14.4-1 -- Rebase to 1.14.4 +* Mon Nov 22 2021 Alejandro Sáez - 1.17.3-1 +- Update to 1.17.3 +- Related: rhbz#2002859 -* Thu May 21 2020 Alejandro Sáez - 1.14.2-2 -- Remove i686 references -- Related: rhbz#1752991 +* Wed Aug 18 2021 Alejandro Sáez - 1.17-1 +- Update to go1.17 +- Resolves: rhbz#1957935 -* Wed May 06 2020 Alejandro Sáez - 1.14.2-1 -- Rebase to 1.14.2 -- Related: rhbz#1820596 +* Mon Aug 09 2021 Alejandro Sáez - 1.17-0.rc2 +- Update to go1.17rc2 +- Update patches +- Remove patch, already in the source https://go-review.googlesource.com/c/go/+/334410/ -* Wed Nov 27 2019 Alejandro Sáez - 1.13.4-2 -- Remove patches -- Related: rhbz#1747150 +* Thu Jul 29 2021 Jakub Čajka - 1.16.6-3 +- fix crash in VDSO calls on ppc64le with new kernels -* Mon Nov 25 2019 Alejandro Sáez - 1.13.4-1 -- Rebase to 1.13.4 -- Related: rhbz#1747150 +* Thu Jul 22 2021 Fedora Release Engineering - 1.16.6-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild -* Tue Sep 17 2019 Tom Stellard - 1.12.8-4 -- Reduce number of threads when testing on i686 +* Wed Jul 14 2021 Mike Rochefort - 1.16.6-1 +- Update to go1.16.6 +- Security fix for CVE-2021-34558 +- Resolves: BZ#1983597 -* Wed Sep 11 2019 Tom Stellard - 1.12.8-3 -- Relax FIPS requirements to unblock OpenShift testing +* Mon Jun 21 2021 Mike Rochefort - 1.16.5-1 +- Update to go1.16.5 +- Security fix for CVE-2021-33195 +- Security fix for CVE-2021-33196 +- Security fix for CVE-2021-33197 +- Fix OOM with large exponents in Rat.SetString gh#45910 -* Wed Aug 28 2019 Tom Stellard - 1.12.8-2 -- Rebase to 1.12.8 -- Resolves: rhbz#1745706 -- Resolves: rhbz#1745712 +* Thu May 13 2021 Jakub Čajka - 1.16.4-2 +- Fix linker issue on ppc64le breaking kube 1.21 build -* Mon Aug 5 2019 Derek Parker - 1.12.6-3 -- Add README for more documentation -- Resolves: rhbz#1734788 +* Mon May 10 2021 Alejandro Sáez - 1.16.4-1 +- Update to go1.16.4 +- Security fix for CVE-2021-31525 +- Resolves: rhbz#1958343 -* Fri Aug 2 2019 Derek Parker - 1.12.6-3 -- Revert some TLS FIPS changes for now -- Resolves: rhbz#1734788 +* Fri Apr 09 2021 Alejandro Sáez - 1.16.3-1 +- Update to go1.16.3 -* Thu Aug 1 2019 Derek Parker - 1.12.6-2 -- Updates to be less strict on key size in FIPS mode -- Resolves: rhbz#1734788 +* Tue Mar 23 2021 Alejandro Sáez - 1.16-2 +- Update to go1.16.2 +- Resolves: rhbz#1937435 -* Thu Jun 13 2019 Derek Parker - 1.12.6-1 +* Thu Feb 18 2021 Jakub Čajka - 1.16-1 +- Update to go1.16 +- Improved bundled provides +- Resolves: BZ#1913835 + +* Sun Jan 31 2021 Neal Gompa - 1.16-0.rc1.1 +- Update to go1.16rc1 +- Related: BZ#1913835 +- Resolves: BZ#1922617 + +* Tue Jan 26 2021 Fedora Release Engineering - 1.16-0.beta1.1.1 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild + +* Fri Jan 15 2021 Jakub Čajka - 1.16-0.beta1.1 +- Update to go1.16beta1 +- Related: BZ#1913835 + +* Fri Dec 04 2020 Jakub Čajka - 1.15.6-1 +- Rebase to go1.15.6 +- Resolves: BZ#1904238 + +* Fri Nov 13 2020 Jakub Čajka - 1.15.5-1 +- Rebase to go1.15.5 +- Security fix for CVE-2020-28362, CVE-2020-28367 and CVE-2020-28366 +- Resolves: BZ#1897342, BZ#1897636, BZ#1897644, BZ#1897647 + +* Fri Nov 06 2020 Jakub Čajka - 1.15.4-1 +- Rebase to go1.15.4 +- Resolves: BZ#1895189 + +* Thu Oct 15 2020 Jakub Čajka - 1.15.3-1 +- Rebase to go1.15.3 +- Resolves: BZ#1888443 + +* Thu Sep 10 2020 Jakub Čajka - 1.15.2-1 +- Rebase to go1.15.2 +- Resolves: BZ#1877565 + +* Thu Sep 03 2020 Jakub Čajka - 1.15.1-1 +- Rebase to go1.15.1 +- Security fix for CVE-2020-24553 +- Resolves: BZ#1874858, BZ#1866892 + +* Wed Aug 12 2020 Jakub Čajka - 1.15-1 +- Rebase to go1.15 proper +- Resolves: BZ#1859241, BZ#1866892 + +* Mon Aug 10 2020 Jakub Čajka - 1.15-0.rc2.0 +- Rebase to go1.15rc1 +- Security fix for CVE-2020-16845 +- Resolves: BZ#1867101 +- Related: BZ#1859241 + +* Mon Jul 27 2020 Fedora Release Engineering - 1.15-0.rc1.0.1 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild + +* Mon Jul 27 2020 Jakub Čajka - 1.15-0.rc1.0 +- Rebase to go1.15rc1 +- Related: BZ#1859241 + +* Mon Jul 20 2020 Jakub Čajka - 1.15-0.beta1.0 +- Rebase to go1.15beta1 + +* Mon Jul 20 2020 Jakub Čajka - 1.14.6-1 +- Rebase to go1.14.6 +- Security fix for CVE-2020-14040 and CVE-2020-15586 +- Resolves: BZ#1842708, BZ#1856957, BZ#1853653 + +* Tue Jun 30 2020 Alejandro Sáez - 1.14.4-1 +- Rebase to go1.14.4 +- Add patch that fixes: https://golang.org/issue/39991 +- Related: BZ#1842708 + +* Mon May 18 2020 Álex Sáez - 1.14.3-1 +- Rebase to go1.14.3 +- Resolves: BZ#1836015 + +* Mon Apr 20 2020 Jakub Čajka - 1.14.2-1 +- Rebase to go1.14.2 +- Resolves: BZ#1815282 + +* Wed Feb 26 2020 Jakub Čajka - 1.14-1 +- Rebase to go1.14 proper +- Resolves: BZ#1792475 + +* Thu Feb 06 2020 Jakub Čajka - 1.14-0.rc1.0 +- Rebase to go1.14.rc1 +- Related: BZ#1792475 + +* Tue Jan 28 2020 Fedora Release Engineering - 1.14-0.beta1.0.1 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild + +* Mon Jan 20 2020 Jakub Čajka - 1.14-0.beta1.0 +- Rebase to go1.14beta1 +- Resolves: BZ#1792475 + +* Mon Jan 13 2020 Jakub Čajka - 1.13.6-1 +- Rebase to go1.13.6 + +* Thu Dec 05 2019 Jakub Čajka - 1.13.5-1 +- Rebase to go1.13.5 + +* Tue Nov 26 2019 Neal Gompa - 1.13.4-2 +- Small fixes to the spec and tighten up the file list + +* Fri Nov 01 2019 Jakub Čajka - 1.13.4-1 +- Rebase to go1.13.4 +- Resolves BZ#1767673 + +* Sat Oct 19 2019 Jakub Čajka - 1.13.3-1 +- Rebase to go1.13.3 +- Fix for CVE-2019-17596 +- Resolves: BZ#1755639, BZ#1763312 + +* Fri Sep 27 2019 Jakub Čajka - 1.13.1-1 +- Rebase to go1.13.1 +- Fix for CVE-2019-16276 +- Resolves: BZ#1755970 + +* Thu Sep 05 2019 Jakub Čajka - 1.13-2 +- Back to go1.13 tls1.3 behavior + +* Wed Sep 04 2019 Jakub Čajka - 1.13-1 +- Rebase to go1.13 + +* Fri Aug 30 2019 Jakub Čajka - 1.13-0.rc2.1 +- Rebase to go1.13rc2 +- Do not enable tls1.3 by default +- Related: BZ#1737471 + +* Wed Aug 28 2019 Jakub Čajka - 1.13-0.rc1.2 +- Actually fix CVE-2019-9514 and CVE-2019-9512 +- Related: BZ#1741816, BZ#1741827 + +* Mon Aug 26 2019 Jakub Čajka - 1.13-0.rc1.1 +- Rebase to 1.13rc1 +- Fix for CVE-2019-14809, CVE-2019-9514 and CVE-2019-9512 +- Resolves: BZ#1741816, BZ#1741827 and BZ#1743131 + +* Thu Aug 01 2019 Jakub Čajka - 1.13-0.beta1.2.2 +- Fix ICE affecting aarch64 +- Resolves: BZ#1735290 + +* Thu Jul 25 2019 Fedora Release Engineering - 1.13-0.beta1.2.1 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild + +* Wed Jul 24 2019 Jakub Čajka - 1.13-0.beta1.2 +- De-configure sumdb and go proxy + +* Wed Jul 24 2019 Jakub Čajka - 1.13-0.beta1.1 +- Rebase to 1.13beta1 +- Related: BZ#1732118 + +* Tue Jul 09 2019 Jakub Čajka - 1.12.7-1 +- Rebase to 1.12.7 +- Resolves: BZ#1728056 + +* Wed Jun 12 2019 Jakub Čajka - 1.12.6-1 - Rebase to 1.12.6 -- Resolves: rhbz#1677819 +- Resolves: BZ#1719483 -* Thu Jun 13 2019 Derek Parker - 1.12.5-2 -- Remove macros present in go-compiler -- Resolves: rhbz#1700109 - -* Wed Jun 12 2019 Derek Parker - 1.12.5-1 +* Tue May 07 2019 Jakub Čajka - 1.12.5-1 - Rebase to 1.12.5 -- Resolves: rhbz#1677819 +- Resolves: BZ#1707187 -* Wed May 29 2019 Derek Parker - 1.12.1-2 -- Lock OpenSSL to specific built version and include more initialization. -- Resolves: rhbz#1709603 +* Mon Apr 08 2019 Jakub Čajka - 1.12.2-1 +- Rebase to 1.12.2 +- Resolves: BZ#1688996 -* Fri May 10 2019 Derek Parker - 1.12.1-1 +* Mon Apr 01 2019 Jakub Čajka - 1.12.1-2 +- Fix up change log, respective CVE has been fixed in go1.12rc1 + +* Fri Mar 15 2019 Jakub Čajka - 1.12.1-1 - Rebase to 1.12.1 -- Include FIPS compliance updates -- Resolves: rhbz#1709603 +- Fix requirement for %%preun (instead of %%postun) scriptlet thanks to Tim Landscheidt +- Use weak deps for SCM deps -* Thu Apr 4 2019 Derek Parker - 1.11.5-2 -- Include patch to fix CVE-2019-9741 -- Resolves: rhbz#1690443 +* Wed Feb 27 2019 Jakub Čajka - 1.12-1 +- Rebase to go1.12 proper +- Resolves: BZ#1680040 -* Mon Feb 18 2019 Derek Parker - 1.11.5-2 -- Switch to pagure fork for Go FIPS +* Mon Feb 18 2019 Jakub Čajka - 1.12-0.rc1.1 +- Rebase to go1.12rc1 -* Thu Feb 7 2019 Derek Parker - 1.11.5-1 -- Rebase to Go 1.11.5 -- Resolves: rhbz#1671277 -- Fixes CVE-2019-6486 +* Thu Jan 31 2019 Fedora Release Engineering - 1.12-0.beta2.2.1 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild -* Thu Jan 3 2019 Derek Parker - 1.11.4-1 -- Rebase to Go 1.11.4 -- Fixes CVE-2018-16873, CVE-2018-16874, CVE-2018-16875 +* Sun Jan 27 2019 Jakub Čajka - 1.12-0.beta2.2 +- Fix for CVE-2019-6486 +- Resolves: BZ#1668973 -* Thu Dec 6 2018 Derek Parker - 1.11.2-1 -- Rebase to Go 1.11.2 +* Fri Jan 11 2019 Jakub Čajka - 1.12-0.beta2.1 +- Rebase to go1.12beta2 -* Fri Nov 16 2018 Derek Parker - 1.10.3-18 -- Remove SCL from macros +* Wed Jan 02 2019 Jakub Čajka - 1.11.4-1 +- Rebase to go1.11.4 +- Fix for CVE-2018-16875, CVE-2018-16874 and CVE-2018-16873 +- Resolves: BZ#1659290, BZ#1659289, BZ#1659288 -* Wed Nov 7 2018 Derek Parker - 1.10.3-17 -- Prefer go-toolset over go-toolset-1.10 -- Resolves: rhbz#1630786 +* Mon Nov 05 2018 Jakub Čajka - 1.11.2-1 +- Rebase to go1.11.2 -* Mon Nov 5 2018 Derek Parker - 1.10.3-16 -- Fix implicit syscall declaration warning +* Thu Oct 04 2018 Jakub Čajka - 1.11.1-1 +- Rebase to go1.11.1 -* Mon Nov 5 2018 Derek Parker - 1.10.3-15 -- Remove usage of redhat hardening flag file, just pass a select few manually -- Resolves: rhbz#1642798 +* Mon Aug 27 2018 Jakub Čajka - 1.11-1 +- Rebase to go1.11 release -* Wed Oct 31 2018 Derek Parker - 1.10.3-14 -- Do not build toolchain in PIE mode -- Resolves: rhbz#1642798 +* Thu Aug 23 2018 Jakub Čajka - 1.11-0.rc2.1 +- Rebase to go1.11rc2 +- Reduce size of bin package -* Fri Oct 26 2018 Derek Parker - 1.10.3-13 -- Fix setting of internal FIPS enabled flag -- Resolves: rhbz#1643653 +* Tue Aug 14 2018 Jakub Čajka - 1.11-0.rc1.1 +- Rebase to go1.11rc1 -* Wed Oct 10 2018 Derek Parker - 1.10.3-12 -- Pass external linker flags to fix annocheck errors -- Resolves: rhbz#1624421 +* Mon Aug 06 2018 Jakub Čajka - 1.11-0.beta3.1 +- Rebase to go1.11beta3 -* Wed Oct 10 2018 Derek Parker - 1.10.3-11 -- Fix UnreachableExceptTests false panic -- Resolves: rhbz#1634748 +* Fri Jul 27 2018 Jakub Čajka - 1.11-0.beta2.2 +- Turn on back DWARF compression by default +- Use less memory on 32bit targets during build +- Resolves: BZ#1607270 +- Related: BZ#1602096 -* Fri Oct 5 2018 Derek Parker - 1.10.3-10 -- Remove SCL, fix bug in boringcrypto with ecdsa -- Related: rhbz#1635066 -- Resolves: rhbz#1636221 +* Fri Jul 20 2018 Jakub Čajka - 1.11-0.beta2.1 +- Rebase to 1.11beta2 -* Wed Sep 26 2018 Derek Parker - 1.10.3-9 -- Add runtime FIPS detection patches -- Resolves: rhbz#1633351 +* Wed Jul 18 2018 Jakub Čajka - 1.11-0.beta1.2 +- Turn off DWARF compression by default as it is not supported by rpm/debuginfo +- Related: BZ#1602096 -* Fri Sep 21 2018 Derek Parker - 1.10.3-8 -- Add `gobuild` and `gotest` macros from go-compilers -- Resolves: rhbz#1631846 +* Fri Jul 13 2018 Fedora Release Engineering - 1.11-0.beta1.1.1 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild -* Thu Sep 20 2018 Derek Parker - 1.10.3-7 -- Bootstrap package using old build of same package -- Resolves: rhbz#1630786 +* Wed Jul 04 2018 Jakub Čajka - 1.11-0.beta1.1 +* Rebase to 1.11beta1 -* Mon Aug 13 2018 Derek Parker - 1.10.3-6 -- Update stack allocation of OpenSSL type patch -- Resolves: rhbz#1615032 +* Fri Jun 08 2018 Jakub Čajka - 1.10.3-1 +- Rebase to 1.10.3 -* Sat Aug 11 2018 Troy Dawson - 1.10.3-5 -- Build on i686 -- Related: bug#1614611 +* Wed May 02 2018 Jakub Čajka - 1.10.2-1 +- Rebase to 1.10.2 -* Tue Aug 7 2018 Derek Parker - 1.10.3-4 -- Add patch fixing stack allocation of opaque OpenSSL type bug. -- Resolves: rhbz#1613538 +* Wed Apr 04 2018 Jakub Čajka - 1.10.1-1 +- Rebase to 1.10.1 +- Resolves: BZ#1562270 -* Thu Aug 2 2018 Derek Parker - 1.10.3-3 -- Add patch with tag to opt out of OpenSSL during build +* Sat Mar 03 2018 Jakub Čajka - 1.10-2 +- Fix CVE-2018-7187 +- Resolves: BZ#1546386, BZ#1546388 -* Wed Jul 25 2018 Derek Parker - 1.10.3-2 -- Add runtime requirement for openssl-devel and misc updates +* Wed Feb 21 2018 Jakub Čajka - 1.10-1 +- Rebase to 1.10 -* Tue Jul 24 2018 Derek Parker - 1.10.3-1 -- Bump to 1.10.3 +* Thu Feb 08 2018 Jakub Čajka - 1.10-0.rc2.1 +- Rebase to 1.10rc2 +- Fix CVE-2018-6574 +- Resolves: BZ#1543561, BZ#1543562 -* Tue Jul 24 2018 Derek Parker - 1.10.2-3 -- Prepare for module build +* Wed Feb 07 2018 Fedora Release Engineering - 1.10-0.rc1.1.1 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild -* Wed Jun 27 2018 Derek Parker - 1.10.2-2 -- Include FIPS patches +* Fri Jan 26 2018 Jakub Čajka - 1.10-0.rc1.1 +- Rebase to 1.10rc1 -* Wed May 23 2018 Derek Parker - 1.10.2-1 -- Bump to Go 1.10.2 +* Fri Jan 12 2018 Jakub Čajka - 1.10-0.beta2.1 +- Rebase to 1.10beta2 -* Thu Mar 15 2018 Derek Parker - 1.10-1 -- Bump to Go 1.10 +* Mon Jan 08 2018 Jakub Čajka - 1.10-0.beta1.1 +- Rebase to 1.10beta1 +- Drop verbose patch as most of it is now implemented by bootstrap tool and is easily toggled by passing -v flag to make.bash -* Wed Oct 18 2017 Jakub Čajka - 1.8.5-1 -- Fix CVE-2017-15041 and CVE-2017-15042 -- Resolves: BZ#1499160, BZ#1498073, BZ#1512063 +* Thu Oct 26 2017 Jakub Čajka - 1.9.2-1 +- Rebase to 1.9.2 +- execute correctly pie tests +- allow to ignore tests via bcond +- reduce size of golang package -* Thu Aug 31 2017 Tom Stellard - 1.8.3-4 -- Explicitly require /usr/bin/gcc -- Resolves: #1487345 +* Fri Oct 06 2017 Jakub Čajka - 1.9.1-1 +- fix CVE-2017-15041 and CVE-2017-15042 -* Thu Jun 22 2017 Jakub Čajka - 1.8.3-3 -- apply asn1 patch -- add ppc64le trampolines patch +* Fri Sep 15 2017 Jakub Čajka - 1.9-1 +- bump to the relased version -* Wed Jun 14 2017 Jakub Čajka - 1.8.3-2 -- regular GTS build +* Wed Aug 02 2017 Fedora Release Engineering - 1.9-0.beta2.1.2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild -* Tue Jun 06 2017 Jakub Čajka - 1.8.3-1 -- initial GTS build +* Wed Jul 26 2017 Fedora Release Engineering - 1.9-0.beta2.1.1 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild + +* Tue Jul 11 2017 Jakub Čajka - 1.9-0.beta2.1 +- bump to beta2 + +* Thu May 25 2017 Jakub Čajka - 1.8.3-1 +- bump to 1.8.3 +- fix for CVE-2017-8932 +- make possible to use 31bit OID in ASN1 +- Resolves: BZ#1454978, BZ#1455191 + +* Fri Apr 21 2017 Jakub Čajka - 1.8.1-2 +- fix uint64 constant codegen on s390x +- Resolves: BZ#1441078 + +* Tue Apr 11 2017 Jakub Čajka - 1.8.1-1 +- bump to Go 1.8.1 +- Resolves: BZ#1440345 + +* Fri Feb 24 2017 Jakub Čajka - 1.8-2 +- avoid possibly stale packages due to chacha test file not being test file + +* Fri Feb 17 2017 Jakub Čajka - 1.8-1 +- bump to released version +- Resolves: BZ#1423637 +- Related: BZ#1411242 * Fri Feb 10 2017 Fedora Release Engineering - 1.8-0.rc3.2.1 - Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild @@ -1378,3 +1619,5 @@ cd .. * Tue Apr 9 2013 Adam Goode - 1.1-0.1.beta1 - Initial packaging. + +## END: Generated by rpmautospec diff --git a/extras/golang/modify_go.env.patch b/extras/golang/modify_go.env.patch deleted file mode 100644 index de7fa82..0000000 --- a/extras/golang/modify_go.env.patch +++ /dev/null @@ -1,27 +0,0 @@ -From d6e201910aa29262851c9274a4cd3645022d3539 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Alejandro=20S=C3=A1ez?= -Date: Tue, 9 Apr 2024 10:05:46 +0200 -Subject: [PATCH] Modify environment variables defaults - -- Set GOTOOLCHAIN to local -- Set GOAMD64 to v2 ---- - go.env | 5 ++++- - 1 file changed, 4 insertions(+), 1 deletion(-) - -diff --git a/go.env b/go.env -index 6ff2b921d4..aadcda023b 100644 ---- a/go.env -+++ b/go.env -@@ -9,4 +9,7 @@ GOSUMDB=sum.golang.org - - # Automatically download newer toolchains as directed by go.mod files. - # See https://go.dev/doc/toolchain for details. --GOTOOLCHAIN=auto -+GOTOOLCHAIN=local -+ -+# The AMD64 baseline for RHEL9 is v2. -+GOAMD64=v2 --- -2.44.0 - diff --git a/extras/golang/skip_TestCrashDumpsAllThreads.patch b/extras/golang/skip_TestCrashDumpsAllThreads.patch deleted file mode 100644 index 92e7eca..0000000 --- a/extras/golang/skip_TestCrashDumpsAllThreads.patch +++ /dev/null @@ -1,27 +0,0 @@ -From fdcaf4e6876cfd910c3da672564be4a6e829047c Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Alejandro=20S=C3=A1ez?= -Date: Wed, 27 Mar 2024 17:15:48 +0100 -Subject: [PATCH] Skip TestCrashDumpsAllThreads - ---- - src/runtime/crash_unix_test.go | 4 ++++ - 1 file changed, 4 insertions(+) - -diff --git a/src/runtime/crash_unix_test.go b/src/runtime/crash_unix_test.go -index 123a462423..a0034d6455 100644 ---- a/src/runtime/crash_unix_test.go -+++ b/src/runtime/crash_unix_test.go -@@ -74,6 +74,10 @@ func TestCrashDumpsAllThreads(t *testing.T) { - t.Skip("skipping; SIGQUIT is blocked, see golang.org/issue/19196") - } - -+ if runtime.GOOS == "linux" && runtime.GOARCH == "s390x" { -+ t.Skip("skipping; frequent TestCrashDumpsAllThreads failures on linux/s390x, see golang.org/issue/64650") -+ } -+ - testenv.MustHaveGoBuild(t) - - if strings.Contains(os.Getenv("GOFLAGS"), "mayMoreStackPreempt") { --- -2.44.0 - diff --git a/extras/golang/skip_test_rhbz1939923.patch b/extras/golang/skip_test_rhbz1939923.patch deleted file mode 100644 index 555ed3b..0000000 --- a/extras/golang/skip_test_rhbz1939923.patch +++ /dev/null @@ -1,12 +0,0 @@ -diff --git a/src/crypto/x509/x509_test.go b/src/crypto/x509/x509_test.go -index b1cdabb..09eaace 100644 ---- a/src/crypto/x509/x509_test.go -+++ b/src/crypto/x509/x509_test.go -@@ -2993,6 +2993,7 @@ func (bs *brokenSigner) Sign(_ io.Reader, _ []byte, _ crypto.SignerOpts) ([]byte - } - - func TestCreateCertificateBrokenSigner(t *testing.T) { -+ t.Skip("TODO Fix me: rhbz#1939923") - template := &Certificate{ - SerialNumber: big.NewInt(10), - DNSNames: []string{"example.com"},